Kyle Posted January 4, 2018 Share Posted January 4, 2018 So you'll notice some of the thumbnails in some of the posts made a long time ago no longer work. The images are still on the server but the HTML is broken, this was due to a bug in the 3.x to 4.x server upgrade. I worked with invision recently and they were able to track down the bug in thier code. Here is an example of a broken thumbnail that does not work:http://data-bass.ipbhost.com/topic/12-the-low-frequency-content-thread-films-games-music-etc/?page=113&tab=comments#comment-7364 The fix for us has some drawbacks. We need to revert back to 3.x then go forward again, this won't lose any posts or threads, but it will wipe out edits to posts or threads since the 3.x to 4.x upgrade which I feel like may have been about a year ago or so. I'll get an exact date on that, but I wanted to ask here to see what you guys think about doing to fix. Just consider that It may cause more issues than we currently have. I don't have any data on how many edits were done between that time. If its just a few non-important edits, no big deal but if we lost a lot of content, then its a big deal. Link to comment Share on other sites More sharing options...
lukeamdman Posted January 4, 2018 Share Posted January 4, 2018 Seems like more trouble than it's worth, and I already fixed the links in a few of my threads. Link to comment Share on other sites More sharing options...
Kyle Posted January 4, 2018 Author Share Posted January 4, 2018 Yes, looking closer, the upgrade was 3 years ago which would mean many edits would be lost. I think its best just to fix links as we find them and move forward. Link to comment Share on other sites More sharing options...
Kyle Posted January 4, 2018 Author Share Posted January 4, 2018 For reference, this is the support thread... Quote I don't know which upgrade caused this issue (if that is even the cause) but I can describe the issue. Please look at this post. Notice the hyperlink for the thumnail image doesn't work. http://data-bass.ipbhost.com/topic/12-the-low-frequency-content-thread-films-games-music-etc/?page=113&tab=comments#comment-7364 Open the HTML inspector (dev tools) and you can see that there is no <a> tag, there is only a <p> that has the <a> tag's href prop. I have numerous posts with this issue and I'm not sure how to mass-fix it. However, It seems like what needs to happen is for each <p> tag that has an "href" prop, we need to convert that to an <a> tag and wrap it around a new <p> tag. <p href=""><img src="thumb.jpg"/></p> to <p><a href=""><img src="thumb.jpg"/></a><p> Can you suggest the best way to curate my posts? Quote Hi Kyle, I have fixed this issue in the software itself - I just wanted to let you know that I am working on a fix for your site specifically. ... I have taken a look here, and unfortunately the only way I can fix this is by restoring the posts from before the upgrade, and rebuilding them again. This will not result in a loss of new posts since the upgrade, however it will result in a loss of any edits made to the ones posted prior to the upgrade. As you are hosted with us, we will take a backup prior to do this. Is it okay to proceed? Link to comment Share on other sites More sharing options...
SME Posted January 5, 2018 Share Posted January 5, 2018 A fix for the pics would be very helpful. A lot of them are broken. FWIW, they broke a lot more recently than 3 years ago, so I assume it was a more recent upgrade. Unfortunately, losing edits made (presumably to old posts) since that upgrade would be a real drag. I suspect a lot of people edited posts to fix broken links to Photobucket since then. I wish there was another way. Link to comment Share on other sites More sharing options...
Kyle Posted March 20, 2018 Author Share Posted March 20, 2018 So the final word here is there is no provided too to do a mass fix. I don't have access to their db to do a mass conversion. What I'm going to attempt to do is learn the REST api (I tried to get it working but there is a problem with the headers right now so I have a support ticket for that. I will query all POST, parse them for broken HTML, change the text to correct HTML, then perform POST requests to edit each one. I'll need to do dry runs first then small tests then probably batch everything and while being careful. none of this is very easy so it might take some time... which is also limited since I'm trying to launched db 2.0 If anyone wants to help with this and knows web , rest and html requests, then I'm happy to delegate Link to comment Share on other sites More sharing options...
Kyle Posted March 22, 2018 Author Share Posted March 22, 2018 Fixed! Link to comment Share on other sites More sharing options...
maxmercy Posted March 23, 2018 Share Posted March 23, 2018 Strong work. JSS Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.